feat: set account alias as tag #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/tag-account-alias
branch
from
bd223ef to
b3b61a4
Compare
AWS Config does not provide account alias directly. We can provide it out of band by tagging resources with the account alias which is resolved at apply time. We must piggy back on either config or configsubscription modules, since otherwise we have no resource data to extract the alias from. We don't have much choice on what to tag, since there are very few resource types across both modules. In `config`, we can only tag IAM resources. In `configsubscription`, only eventbridge rules can be tagged.
jta
force-pushed
the
joao/tag-account-alias
branch
from
b3b61a4 to
882f12f
Compare
obs-gh-abhishekrao
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Config does not provide account alias directly. We can provide it out of band by tagging resources with the account alias which is resolved at apply time. We must piggy back on either config or configsubscription modules, since otherwise we have no resource data to extract the alias from.
We don't have much choice on what to tag, since there are very few resource types across both modules. In
config, we can only tag IAM resources. Inconfigsubscription, only eventbridge rules can be tagged.